From 0e080b10670b507709889db02d11bb33c5e43893 Mon Sep 17 00:00:00 2001
From: viktorskabiak <viktor.skabiak@inoxoft.com>
Date: Thu, 19 May 2022 02:09:02 +0300
Subject: [PATCH] fixed Memory leak when opening PDF as a byte array

---
 src/main/jni/src/mainJNILib.cpp | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/main/jni/src/mainJNILib.cpp b/src/main/jni/src/mainJNILib.cpp
index a888e69..0067e4b 100644
--- a/src/main/jni/src/mainJNILib.cpp
+++ b/src/main/jni/src/mainJNILib.cpp
@@ -55,6 +55,9 @@ class DocumentFile {
     FPDF_DOCUMENT pdfDocument = NULL;
     size_t fileSize;
 
+    public:
+    jbyte *cDataCopy = NULL;
+
     DocumentFile() { initLibraryIfNeed(); }
     ~DocumentFile();
 };
@@ -62,7 +65,10 @@ DocumentFile::~DocumentFile(){
     if(pdfDocument != NULL){
         FPDF_CloseDocument(pdfDocument);
     }
-
+    if(cDataCopy != NULL){
+        free(cDataCopy);
+        cDataCopy = NULL;
+    }
     destroyLibraryIfNeed();
 }
 
@@ -238,13 +244,11 @@ JNI_FUNC(jlong, PdfiumCore, nativeOpenMemDocument)(JNI_ARGS, jbyteArray data, js
         cpassword = env->GetStringUTFChars(password, NULL);
     }
 
-    jbyte *cData = env->GetByteArrayElements(data, NULL);
     int size = (int) env->GetArrayLength(data);
     jbyte *cDataCopy = new jbyte[size];
-    memcpy(cDataCopy, cData, size);
+    env->GetByteArrayRegion(data, 0, size, cDataCopy);
     FPDF_DOCUMENT document = FPDF_LoadMemDocument( reinterpret_cast<const void*>(cDataCopy),
                                                           size, cpassword);
-    env->ReleaseByteArrayElements(data, cData, JNI_ABORT);
 
     if(cpassword != NULL) {
         env->ReleaseStringUTFChars(password, cpassword);
@@ -269,7 +273,7 @@ JNI_FUNC(jlong, PdfiumCore, nativeOpenMemDocument)(JNI_ARGS, jbyteArray data, js
     }
 
     docFile->pdfDocument = document;
-
+    docFile->cDataCopy = cDataCopy;
     return reinterpret_cast<jlong>(docFile);
 }