Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compactor didnt respect days as units for retention policies #60

Open
Ultrafenrir opened this issue Oct 28, 2020 · 1 comment
Open

Compactor didnt respect days as units for retention policies #60

Ultrafenrir opened this issue Oct 28, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Ultrafenrir
Copy link
Contributor

Describe the bug
When i try to set retention for compactor for example for 30d, the following error occurring:

E1028 11:06:51.065884 807 reflector.go:178] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:125: Failed to list *v1alpha1.ObjectStore: v1alpha1.ObjectStoreList.Items: []v1alpha1.ObjectStore: v1alpha1.ObjectStore.Spec: v1alpha1.ObjectStoreSpec.Compactor: v1alpha1.Compactor.RetentionResolution5m: RetentionResolution1h: unmarshalerDecoder: time: unknown unit d in duration 30d, error found in #10 byte of ...|n1h":"30d","retentio|..., bigger context ...|or-iam-eks-sbx-eu"}},"retentionResolution1h":"30d","retentionResolution5m":"30d","retentionResolutio|... 28/10/2020 13:07:39

Steps to reproduce the issue:
Set any of retentionResolution1h/retentionResolution5m/retentionResolutionraw as 30d

Expected behavior
It should respect any units ( hours, days, years)

Additional context
working with hours (h)

@tarokkk tarokkk self-assigned this Oct 28, 2020
@tarokkk tarokkk added the bug Something isn't working label Oct 28, 2020
@viennaa
Copy link

viennaa commented Jun 7, 2022

Just dug a little bit into this, the behaviour is expected by the metav1.Duration used from Go here.

Citing the possible units
Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".

I would close this, as it is not a bug. Maybe the documentation could be improved a litte instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants