Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch test file from jld2 to daec #53

Merged
merged 9 commits into from
May 17, 2024
Merged

Switch test file from jld2 to daec #53

merged 9 commits into from
May 17, 2024

Conversation

jasonjensen
Copy link
Contributor

This PR simply replaces our single jld2 test file with a daec file and removed the JLD2 dependency from the package.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (67de858) to head (4907bc3).

Current head 4907bc3 differs from pull request most recent head 6f2a708

Please upload reports for the commit 6f2a708 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   89.06%   89.11%   +0.04%     
==========================================
  Files          31       31              
  Lines        2305     2305              
==========================================
+ Hits         2053     2054       +1     
+ Misses        252      251       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbejanov bbejanov merged commit 141035e into master May 17, 2024
9 checks passed
@bbejanov bbejanov deleted the remove-JLD2 branch May 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants