Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using parent context in balena build #1704

Open
StefKors opened this issue Apr 8, 2020 · 4 comments
Open

Add support for using parent context in balena build #1704

StefKors opened this issue Apr 8, 2020 · 4 comments

Comments

@StefKors
Copy link

StefKors commented Apr 8, 2020

Docker-compose supports using a context that is the parent of the current location. balena build explicitly limits this behavior to the child's scope. Originally this was added to ensure the code doesn't escape the directory you run it in. If the balena build command also supports the parent context it can improve the multi-container, multi-device workflow.

Related to this forum thread: https://forums.balena.io/t/multi-container-multi-device-with-a-single-code-base/92161

@jellyfish-bot
Copy link

[stefkors] This issue has attached support thread https://jel.ly.fish/#/ba5e6623-cd03-4d8e-be08-19ca39450d8d

@dtischler
Copy link

User has also identified another possible implementation:

"
Another option might be to make it possible to specify a Docker Compose file from the CLI. For example:
$ balena deploy --build --docker-compose my-docker-compose.yml
"

@pdcastro
Copy link
Contributor

pdcastro commented Apr 8, 2020

Docker-compose supports using a context that is the parent of the current location

It sounds like this refers to the docker-compose --file and --project-directory options:

$ docker-compose --help
...
  -f, --file FILE             Specify an alternate compose file
                              (default: docker-compose.yml)
  --project-directory PATH    Specify an alternate working directory
                              (default: the path of the Compose file)

In which case, I think it boils down to accepting the docker-compose.yml file to be in a different folder than the context = project directory, which in turns has the same effect as issue #1142 Add ability to select a docker-compose file. That issue is frequently requested and it is now very high up in the backlog.

I'll leave this issue open, but I think it could be closed when #1142 is released.

@jellyfish-bot
Copy link

[the-real-kenna] This issue has attached support thread https://jel.ly.fish/44dd2470-431d-4327-917b-51a7e22181ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants