Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balena build help missing -f flag #1687

Closed
srlowe opened this issue Mar 31, 2020 · 4 comments
Closed

balena build help missing -f flag #1687

srlowe opened this issue Mar 31, 2020 · 4 comments
Assignees

Comments

@srlowe
Copy link
Contributor

srlowe commented Mar 31, 2020

balena build help mentions that an alternative dockerfile can be specified with the -f flag, but there is no alias defined for --dockerfile.

@pdcastro This appears to be defined in utils/compose.coffee appendOptions. I'll check if this was omitted for a reason (perhaps collides somewhere that uses appendOptions). Do you know of any reason this is not defined?

@srlowe srlowe self-assigned this Mar 31, 2020
@pdcastro
Copy link
Contributor

Do you know of any reason this is not defined?

@srlowe, actually I do! In a CLI check-in about a year ago, :-) I remember proposing the -f option to match docker build, but then someone else pointed out that docker-compose also uses -f to select an alternative docker-compose.yml file, and we would like the CLI push/build/deploy commands to be able to specify an alternative docker-compose.yml as well (pending issue #1142), and they could not both be -f. I had suggested having different single-char options, but somewhat to my surprise everybody else (Shaun, Cameron, Hedley, Akis) thought it was preferable not to have any single-character option at all, having only the --dockerfile long option name. I must have dropped the single-character option from the code but I guess I forgot to update the help output to match it. So the action to be taken would be to edit the help text to remove any reference to a -f option, unless you wanted to reopen the discussion with the product team. :-)

@srlowe
Copy link
Contributor Author

srlowe commented Apr 1, 2020

@pdcastro Ah thanks! I'll update the help.

@srlowe
Copy link
Contributor Author

srlowe commented Apr 7, 2020

Fixed in PR #1691

@srlowe srlowe closed this as completed Apr 7, 2020
@jellyfish-bot
Copy link

[the-real-kenna] This issue has attached support thread https://jel.ly.fish/44dd2470-431d-4327-917b-51a7e22181ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants