Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using CRSF set to true returns forbidden as response on api calls #7324

Open
andre-ticloudged opened this issue Mar 21, 2024 · 2 comments
Open

Comments

@andre-ticloudged
Copy link

Node version: 20.10.0
Sails version (sails): 1.5.8
ORM hook version (sails-hook-orm): 4.0.0
Sockets hook version (sails-hook-sockets):2.0.0
Grunt hook version (sails-hook-grunt): 5.0.0
Uploads hook version (sails-hook-uploads): 0.4.3
DB adapter & version :[email protected]


Hello, i'm having a problem with the CSRF configuration, the requests always hits the HTTP 403 forbidden response. Thanks in advance!

Following the docs, i set the route to get the crsf token to this:

'GET /csrfToken': { action: 'security/grant-csrf-token' }


And the cors configuration to:

cors: {
     allRoutes: true,
     allowCredentials: true,
     allowOrigins: ['http://127.0.0.1:3000', 'http://localhost:3000'],
     allowRequestHeaders: 'content-type,x-csrf-token,authorization',
     allowRequestMethods: 'GET,POST,PUT,DELETE,OPTIONS,PATCH'
   },
  csrf: true,

I am able to acess the crsf token in the url http://localhost:1337/csrfToken

The request to the api are being made like this:

const request = await fetch(http://localhost:1337/api/v1/my-endpoint`, {
                method: 'POST',
                credentials:"same-origin",
                headers: {
                    'X-CSRF-Token': csrfToken,
                    'Content-Type': 'application/json',
                    "authorization" : `Bearer ${sessionValues.token}`,
                },
                body: 
                    JSON.stringify({
                    _csrf: csrfToken,
                })
            });
@sailsbot
Copy link

@andre-ticloudged Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@G0x209C
Copy link

G0x209C commented Jun 7, 2024

What is the code doing around it?
Have you been able to solve it?
Have you made sure that the CSRF token is always used once, and once only?
They are consumed.

But without a modicum of context it's difficult to assert why you're getting a 403.

I also see you're setting it in the headers, maybe don't do that since the documentation specifies it must be part of the body or the request's url_query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants