Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store PyTorch version somewhere in libnitorch #19

Open
balbasty opened this issue Oct 14, 2020 · 0 comments
Open

Store PyTorch version somewhere in libnitorch #19

balbasty opened this issue Oct 14, 2020 · 0 comments
Assignees
Labels
build / ci Build system or continuous integration language: c++ Relates to C++/CUDA code

Comments

@balbasty
Copy link
Owner

NiTorch's c++/cuda library (libnitorch) is compiled against pytorch's c++/cuda library (libtorch). From one version of pytorch to the next, changes in libtorch can cause symbols to disappear, leading to errors when the library that's loaded at runtime differs from the one used at build time (say if nitorch is compiled against pytorch 1.5 but pytorch 1.6 is used at run time).

We should at least have a way to check, when nitorch is loaded, that it is compatible with the current pytorch version. To do that, we need to store pytorch's version somewhere in libnitorch at build time and have a python binding so that it can be inspected at run time.

@balbasty balbasty added build / ci Build system or continuous integration language: c++ Relates to C++/CUDA code labels Oct 14, 2020
@balbasty balbasty self-assigned this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build / ci Build system or continuous integration language: c++ Relates to C++/CUDA code
Projects
None yet
Development

No branches or pull requests

1 participant