You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if (order.buyAmount >bmul(buyTokenBalance, MAX_IN_RATIO)) {
revertBPool_TokenAmountInAboveMaxRatio();
}
Expected behavior
The helper contract only suggests orders which would later on pass verification. In this case the limit amount should be scaled down to comply with MAX_IN_RATIO.
The text was updated successfully, but these errors were encountered:
Currently, the helper contract may suggest orders that are later on rejected by the verification logic (cf. this settlement).
This is due to certain invariants in the
verify
function, e.g.cow-amm/src/contracts/BCoWPool.sol
Lines 124 to 127 in f3f77d1
Expected behavior
The helper contract only suggests orders which would later on pass verification. In this case the limit amount should be scaled down to comply with
MAX_IN_RATIO
.The text was updated successfully, but these errors were encountered: