Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review artifacts in deployments package #2258

Open
jubeira opened this issue Feb 14, 2023 · 2 comments
Open

Review artifacts in deployments package #2258

jubeira opened this issue Feb 14, 2023 · 2 comments

Comments

@jubeira
Copy link
Contributor

jubeira commented Feb 14, 2023

There might be some relevant missing artifacts from the latest deployments.

In general, by default we create one artifact that matches the build info name. But for pool deployments, there should be at least a pool + factory artifact (optionally with rebalancer or other auxiliary contracts).

Related with #1503; this could be standarized with the deployment.

@EndymionJkb
Copy link
Collaborator

EndymionJkb commented Feb 14, 2023

What we should do ultimately depends on who is using the artifact files and for what purpose. It looked like the deployment tasks always used the build-info, but the artifacts are used in unit tests (e.g., to extract abi, bytecode, etc.)

@nventuro
Copy link
Contributor

The artifacts are what is published by npm: we can't publish the entire build info as that'd be too much data (and the package should be somewhat lightweight). The artifacts should contain abi + creation code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants