Allow passing asset managers to ComposableStablePool #2142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asset managers are extremely powerful: they can withdraw all funds. Allowing pools to be deployed from the canonical factory with arbitrary asset managers would greatly compromise security. The safe way to deploy a pool with asset managers is illustrated by Linear and Managed Pools: make a factory that deploys both the pool and a specific asset manager contract (e.g., a LinearPoolRebalancer or pool controller). Then users would be able to review the contracts and determine the safety of pools deployed from that factory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the ability to pass asset managers when deploying ComposableStablePool. Previously the contract hardcoded zero-address.
Background info at #2141.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution
Fixes #2141