Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Splitter default allocation be factory-based #2050

Open
nventuro opened this issue Nov 23, 2022 · 0 comments
Open

Make the Splitter default allocation be factory-based #2050

nventuro opened this issue Nov 23, 2022 · 0 comments

Comments

@nventuro
Copy link
Contributor

The ProtocolFeeSplitter currently has a single default fee allocation. This is too coarse, it's unlikely the current behavior would ever be used as Pools are too different.

Ideally, we'd be able to set different default fees for each Pool factory. The trouble here is that we'd then need to find the factory for each Pool whenever tokens are withdrawn, but the list of factories should not be very large (likely ~5), so this would not be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant