Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear Pool: consider removing minimumBPT override #1958

Open
EndymionJkb opened this issue Oct 28, 2022 · 0 comments
Open

Linear Pool: consider removing minimumBPT override #1958

EndymionJkb opened this issue Oct 28, 2022 · 0 comments

Comments

@EndymionJkb
Copy link
Collaborator

Most pools mint an initial (very small) amount of BPT to the zero address on initialization, so that the pool can never be completely drained. Most importantly, this prevents _onInitializePool from being called more than once. (And also helps avoid math issues at very low liquidity.)

Linear Pools override and set this to 0, since the preminting also avoids any such issue (as it would with any composable pool). This results in a slight increase in complexity (e.g., we have to override a function, and we also get an event from minting 0 tokens), so we could remove this, and let it mint the premint amount + epsilon, same as other pools.

@nventuro nventuro mentioned this issue Oct 28, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant