Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Base config #503

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add Base config #503

merged 1 commit into from
Jul 31, 2023

Conversation

timjrobinson
Copy link
Contributor

Addresses from balancer/balancer-deployments#69

Tested locally and it works for me.

@timjrobinson timjrobinson mentioned this pull request Jul 31, 2023
Merged
6 tasks
brunoguerios
brunoguerios previously approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check each single address, but the ones I compared are matching. LGTM 👍

@brunoguerios brunoguerios dismissed their stale review July 31, 2023 13:11

Didn't see there were failing tests

@johngrantuk johngrantuk merged commit a1224b4 into develop Jul 31, 2023
2 of 3 checks passed
@johngrantuk johngrantuk deleted the feat/base branch July 31, 2023 13:24
@johngrantuk johngrantuk mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoguerios brunoguerios brunoguerios left review comments

@lgahdl lgahdl Awaiting requested review from lgahdl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timjrobinson @brunoguerios @johngrantuk