Merge pull request #489 from balancer/composable-v5

Remove CS pool version check from join concern
balancer · Jul 17, 2023 · 3941002 · 3941002
2 parents f83d643 + 605f231
commit 3941002
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/balancer-js/src/modules/pools/pool-types/concerns/composableStable/join.concern.ts b/balancer-js/src/modules/pools/pool-types/concerns/composableStable/join.concern.ts
@@ -107,20 +107,16 @@ export class ComposableStablePoolJoin implements JoinConcern {
      * V2: Reintroduced proportional exits. Has vulnerability.
      * V3: Fixed vulnerability. Functionally the same as V2.
      * V4: Update to use new create method with new salt parameter
+     * V5: Fixed vulnerability. Functionally the same as V4.
      */
-    if (pool.poolTypeVersion <= 4)
-      return this.sortV1(wrappedNativeAsset, tokensIn, amountsIn, pool);
+    return this.sortV1(wrappedNativeAsset, tokensIn, amountsIn, pool);
     // Not release yet and needs tests to confirm
     // else if (values.pool.poolTypeVersion === 5)
     //   sortedValues = this.sortV4(
     //     values.tokensIn,
     //     values.amountsIn,
     //     values.pool
     //   );
-    else
-      throw new Error(
-        `Unsupported ComposablePool Version ${pool.poolTypeVersion}`
-      );
   }
 
   /**