New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postfix #1

Open

mjallday opened this issue Oct 8, 2014 · 3 comments

Labels

mjallday commented Oct 8, 2014

https://github.com/jdauphant/ansible-role-postfix/blob/master/defaults/main.yml

can clone settings from https://github.com/balanced-cookbooks/role-base/commit/c9dac54224226bd2ed7763cc1b7fbe9aa42f4233

mjallday added the enhancement label

Contributor

mahmoudimus commented Oct 25, 2014

@mjallday see this: https://github.com/balanced-cookbooks/infra-global/pull/15

Do you think we should move this to base?

If this is the case, then shouldn't we move all this https://github.com/balanced-cookbooks/infra-global/blob/postfix/site.yml#L18-L29 in this role?

Author

mjallday commented Oct 25, 2014

that's a fair point.

what exactly is the point of role base?

Contributor

mahmoudimus commented Oct 26, 2014

I think role-base is supposed to just include common reusable tasks that we can build on top in our ansible roles.

I think every task here need to have an {{ common_task_name}}_enabled option so we can control how they get executed.

I think it makes sense to have a common role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment