Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Spell names show as numbers #31

Open
Esennee opened this issue Sep 30, 2024 · 5 comments
Open

[BUG] Spell names show as numbers #31

Esennee opened this issue Sep 30, 2024 · 5 comments

Comments

@Esennee
Copy link

Esennee commented Sep 30, 2024

Describe the bug
When casting a healing spell, next to the number healed on the floating text, it shows a long number.

To Reproduce
Steps to reproduce the behavior:

  1. Cast any healing spell on yourself or others (HT, regrowth, etc.)

Expected behavior
The long text after the spell name shouldn't exist.
Uploading WoWScrnShot_093024_182145.png…

@balakethelock
Copy link
Owner

The uploaded image doesn't work

@Esennee
Copy link
Author

Esennee commented Sep 30, 2024

WoWScrnShot_093024_182145

@Esennee
Copy link
Author

Esennee commented Sep 30, 2024

Tried disabling all addons first, but the issue persisted. It doesn't happen on healing ticks, just on the initial cast. I tried downloading and updating superwow again, but nothing changed.

@balakethelock
Copy link
Owner

Ah yes, you probably have raw GUIDs in combat log mode.
The fix is possible but requires to happen on addon side, so this is a problem for SuperAPI

https://github.com/refaim/Turtle-WoW-UI-Source/blob/d6137c2ebd291f10ce284e586a5733dd5141bef2/Interface/AddOns/Blizzard_CombatText/Blizzard_CombatText.lua#L177
In this line it has to figure out if the event's data is a GUID and get the name from the GUID before printing it in the scrolling combat text.

@Esennee
Copy link
Author

Esennee commented Oct 1, 2024

I don't understand much about coding, but how can I fix it? I need to change some lines on the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants