From 8dd2ab65ad59d80c0cff85f3e8e0a40f55168d50 Mon Sep 17 00:00:00 2001
From: "Jessica S. Yu" <15913767+jessicasyu@users.noreply.github.com>
Date: Wed, 15 Feb 2023 15:45:03 -0500
Subject: [PATCH] Fix type hints (#33)

* FIx type hints in docker and fargate tasks

* Update pytest cov version
---
 poetry.lock                                               | 8 ++++----
 pyproject.toml                                            | 2 +-
 src/container_collection/docker/create_docker_volume.py   | 2 +-
 src/container_collection/fargate/register_fargate_task.py | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/poetry.lock b/poetry.lock
index 5a13aba..66a329d 100644
--- a/poetry.lock
+++ b/poetry.lock
@@ -1108,7 +1108,7 @@ testing = ["argcomplete", "hypothesis (>=3.56)", "mock", "nose", "pygments (>=2.
 
 [[package]]
 name = "pytest-cov"
-version = "3.0.0"
+version = "4.0.0"
 description = "Pytest plugin for measuring coverage."
 category = "dev"
 optional = false
@@ -1685,7 +1685,7 @@ testing = ["flake8 (<5)", "func-timeout", "jaraco.functools", "jaraco.itertools"
 [metadata]
 lock-version = "1.1"
 python-versions = "^3.9"
-content-hash = "0a0fea8b968ae61a0129fbfadfbda2e69552e793859598d4d2722dc9e2e255b7"
+content-hash = "7e67d8d3e65ddd26247ff8e6537781a5d9dba2b2afc672ada83da0e13a23ff5b"
 
 [metadata.files]
 aiofiles = [
@@ -2728,8 +2728,8 @@ pytest = [
     {file = "pytest-7.2.0.tar.gz", hash = "sha256:c4014eb40e10f11f355ad4e3c2fb2c6c6d1919c73f3b5a433de4708202cade59"},
 ]
 pytest-cov = [
-    {file = "pytest-cov-3.0.0.tar.gz", hash = "sha256:e7f0f5b1617d2210a2cabc266dfe2f4c75a8d32fb89eafb7ad9d06f6d076d470"},
-    {file = "pytest_cov-3.0.0-py3-none-any.whl", hash = "sha256:578d5d15ac4a25e5f961c938b85a05b09fdaae9deef3bb6de9a6e766622ca7a6"},
+    {file = "pytest-cov-4.0.0.tar.gz", hash = "sha256:996b79efde6433cdbd0088872dbc5fb3ed7fe1578b68cdbba634f14bb8dd0470"},
+    {file = "pytest_cov-4.0.0-py3-none-any.whl", hash = "sha256:2feb1b751d66a8bd934e5edfa2e961d11309dc37b73b0eabe73b5945fee20f6b"},
 ]
 pytest-subtests = [
     {file = "pytest-subtests-0.8.0.tar.gz", hash = "sha256:46eb376022e926950816ccc23502de3277adcc1396652ddb3328ce0289052c4d"},
diff --git a/pyproject.toml b/pyproject.toml
index 979cde6..381f426 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -24,7 +24,7 @@ isort = "^5.12.0"
 mypy = "^0.971"
 pylint = "^2.15.2"
 pytest = "^7.2.0"
-pytest-cov = "^3.0.0"
+pytest-cov = "^4.0.0"
 pytest-subtests = "^0.8.0"
 Sphinx = "^5.1.1"
 sphinx-rtd-theme = "^1.0.0"
diff --git a/src/container_collection/docker/create_docker_volume.py b/src/container_collection/docker/create_docker_volume.py
index 205a2c1..32d9d7b 100644
--- a/src/container_collection/docker/create_docker_volume.py
+++ b/src/container_collection/docker/create_docker_volume.py
@@ -3,7 +3,7 @@
 
 
 @task
-def create_docker_volume(path: int) -> docker.models.volumes.Volume:
+def create_docker_volume(path: str) -> docker.models.volumes.Volume:
     client = docker.DockerClient(base_url="unix://var/run/docker.sock")
     volume = client.volumes.create(
         driver="local", driver_opts={"type": "none", "device": path, "o": "bind"}
diff --git a/src/container_collection/fargate/register_fargate_task.py b/src/container_collection/fargate/register_fargate_task.py
index bd8fc98..c958229 100644
--- a/src/container_collection/fargate/register_fargate_task.py
+++ b/src/container_collection/fargate/register_fargate_task.py
@@ -4,7 +4,7 @@
 
 
 @task
-def register_fargate_task(task_definition: dict) -> None:
+def register_fargate_task(task_definition: dict) -> str:
     client = boto3.client("ecs")
     response = client.list_task_definitions(familyPrefix=task_definition["family"])