Skip to content

Commit 9409ea2

Browse files
committed
sdk-core: remove attachment record limits [INT-355]
1 parent cf3f88a commit 9409ea2

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

packages/sdk-core/src/BacktraceCoreClient.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ export abstract class BacktraceCoreClient<
202202
},
203203
setup.database?.reportRecordFactory ?? DefaultReportBacktraceDatabaseRecordFactory.default(),
204204
this.sessionFiles,
205+
setup.database.recordLimits,
205206
);
206207
this._modules.set(BacktraceDatabase, database);
207208
}

packages/sdk-core/src/builder/CoreClientSetup.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { BacktraceStackTraceConverter } from '../modules/converter/index.js';
88
import { BacktraceDatabaseRecordSenders } from '../modules/database/BacktraceDatabaseRecordSender.js';
99
import { BacktraceDatabaseRecordSerializers } from '../modules/database/BacktraceDatabaseRecordSerializer.js';
1010
import { ReportBacktraceDatabaseRecordFactory } from '../modules/database/ReportBacktraceDatabaseRecordFactory.js';
11+
import { BacktraceDatabaseRecordCountByType } from '../modules/database/index.js';
1112
import { BacktraceSessionProvider } from '../modules/metrics/BacktraceSessionProvider.js';
1213
import { MetricsQueue } from '../modules/metrics/MetricsQueue.js';
1314
import { SummedEvent } from '../modules/metrics/model/SummedEvent.js';
@@ -39,5 +40,6 @@ export interface CoreClientSetup<O extends BacktraceConfiguration = BacktraceCon
3940
readonly recordSerializers?: BacktraceDatabaseRecordSerializers;
4041
readonly recordSenders?: (submission: BacktraceReportSubmission) => BacktraceDatabaseRecordSenders;
4142
readonly reportRecordFactory?: ReportBacktraceDatabaseRecordFactory;
43+
readonly recordLimits?: BacktraceDatabaseRecordCountByType;
4244
};
4345
}

packages/sdk-core/src/model/configuration/BacktraceDatabaseConfiguration.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,6 @@ export interface EnabledBacktraceDatabaseConfiguration {
1717
*/
1818
maximumNumberOfRecords?: number;
1919

20-
/**
21-
* The maximum number of attachments stored in the offline database. When the limit is reached,
22-
* the oldest attachments are removed. If the value is equal to '0', then no limit is set.
23-
* @default 10
24-
*/
25-
maximumNumberOfAttachmentRecords?: number;
26-
2720
/**
2821
* The amount of time (in ms) to wait between retries if the database is unable to send a report.
2922
* The default value is 60 000

packages/sdk-core/src/modules/database/BacktraceDatabase.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,14 @@ export class BacktraceDatabase extends Events<BacktraceDatabaseEvents> implement
4444
private readonly _recordSenders: BacktraceDatabaseRecordSenders,
4545
private readonly _reportRecordFactory: ReportBacktraceDatabaseRecordFactory,
4646
private readonly _sessionFiles?: SessionFiles,
47+
recordLimits?: BacktraceDatabaseRecordCountByType,
4748
) {
4849
super();
4950

5051
this._databaseRecordContext = new BacktraceDatabaseContext(this._options?.maximumRetries);
5152
this._recordLimits = {
5253
report: this._options?.maximumNumberOfRecords ?? 8,
53-
attachment: this._options?.maximumNumberOfAttachmentRecords ?? 10,
54+
...recordLimits,
5455
};
5556
this._retryInterval = this._options?.retryInterval ?? 60_000;
5657
}

packages/sdk-core/tests/database/databaseSetupTests.spec.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,6 @@ describe('Database setup tests', () => {
204204
const database = new BacktraceDatabase(
205205
{
206206
autoSend: false,
207-
maximumNumberOfRecords: 2,
208-
maximumNumberOfAttachmentRecords: 3,
209207
},
210208
testStorageProvider,
211209
{
@@ -219,6 +217,11 @@ describe('Database setup tests', () => {
219217
),
220218
},
221219
DefaultReportBacktraceDatabaseRecordFactory.default(),
220+
undefined,
221+
{
222+
report: 2,
223+
attachment: 3,
224+
},
222225
);
223226

224227
const databaseStartResult = database.initialize();

0 commit comments

Comments
 (0)