From c85344725a481145e4ec7589aed15f0efd86035d Mon Sep 17 00:00:00 2001 From: Bartosz Litwiniuk <> Date: Tue, 28 Nov 2023 23:43:23 +0100 Subject: [PATCH 1/4] Fix classifier value, use value from report --- .../library/models/BacktraceDataTest.java | 40 +++++++++++++++++++ .../models/json/BacktraceAttributes.java | 2 +- 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 backtrace-library/src/androidTest/java/backtraceio/library/models/BacktraceDataTest.java diff --git a/backtrace-library/src/androidTest/java/backtraceio/library/models/BacktraceDataTest.java b/backtrace-library/src/androidTest/java/backtraceio/library/models/BacktraceDataTest.java new file mode 100644 index 00000000..c686c966 --- /dev/null +++ b/backtrace-library/src/androidTest/java/backtraceio/library/models/BacktraceDataTest.java @@ -0,0 +1,40 @@ +package backtraceio.library.models; + +import static org.junit.Assert.assertEquals; + +import android.content.Context; + +import androidx.test.ext.junit.runners.AndroidJUnit4; +import androidx.test.platform.app.InstrumentationRegistry; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; + +import java.util.HashMap; + +import backtraceio.library.models.json.BacktraceReport; + +@RunWith(AndroidJUnit4.class) +public class BacktraceDataTest { + private Context context; + + @Before + public void setUp() { + context = InstrumentationRegistry.getInstrumentation().getContext(); + } + + @Test + public void createBacktraceDataTest() { + // GIVEN + BacktraceReport report = new BacktraceReport(new IllegalAccessException("test-message")); + + // WHEN + BacktraceData backtraceData = new BacktraceData(context, report, new HashMap<>()); + + // THEN + assertEquals(backtraceData.classifiers, new String[]{"java.lang.IllegalAccessException"}); + assertEquals(backtraceData.report, report); + assertEquals(backtraceData.attributes.get("classifier"), "java.lang.IllegalAccessException"); + } +} diff --git a/backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceAttributes.java b/backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceAttributes.java index ebfde757..de9d247c 100644 --- a/backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceAttributes.java +++ b/backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceAttributes.java @@ -157,7 +157,7 @@ private void setExceptionAttributes(BacktraceReport report) { this.attributes.put("error.message", report.message); return; } - this.attributes.put("classifier", report.exception.getClass().getName()); + this.attributes.put("classifier", report.classifier); this.attributes.put("error.message", report.exception.getMessage()); } From 4957ac2a6f73657c2b1b46fef50d7dcf5bd5fc4d Mon Sep 17 00:00:00 2001 From: Bartosz Litwiniuk <> Date: Tue, 28 Nov 2023 23:58:59 +0100 Subject: [PATCH 2/4] Fix region --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cd6a1ad5..ead22943 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -100,7 +100,7 @@ jobs: - name: Run Saucectl run: | - saucectl configure --username ${{ secrets.SAUCE_USERNAME }} --accessKey ${{ secrets.SAUCE_ACCESS_KEY }} + saucectl configure --username ${{ secrets.SAUCE_USERNAME }} --accessKey ${{ secrets.SAUCE_ACCESS_KEY }} --region eu-central-1 # recent real device saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name="Samsung_Galaxy_S20_FE_5G_backtrace_us" # newest Android version From 7510862c14751e50de43fbe027b2a1a47b8fe11f Mon Sep 17 00:00:00 2001 From: Bartosz Litwiniuk <> Date: Wed, 29 Nov 2023 00:08:21 +0100 Subject: [PATCH 3/4] Fix region --- .github/workflows/test.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ead22943..e05eaad4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -100,15 +100,15 @@ jobs: - name: Run Saucectl run: | - saucectl configure --username ${{ secrets.SAUCE_USERNAME }} --accessKey ${{ secrets.SAUCE_ACCESS_KEY }} --region eu-central-1 + saucectl configure --username ${{ secrets.SAUCE_USERNAME }} --accessKey ${{ secrets.SAUCE_ACCESS_KEY }} # recent real device - saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name="Samsung_Galaxy_S20_FE_5G_backtrace_us" + saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name="Samsung_Galaxy_S20_FE_5G_backtrace_us" --region eu-central-1 # newest Android version - saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --emulator name="Android GoogleApi Emulator,platformVersion=12.0" + saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --emulator name="Android GoogleApi Emulator,platformVersion=12.0" --region eu-central-1 # oldest Android version - saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --emulator name="Android GoogleApi Emulator,platformVersion=5.1" + saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --emulator name="Android GoogleApi Emulator,platformVersion=5.1" --region eu-central-1 # oldest real device (aiming for armv7 / 32bit) - saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name=".*,platformVersion=6.0.1" + saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name=".*,platformVersion=6.0.1" --region eu-central-1 # --device name=".*,platformVersion=6.0.1" # --device name="Samsung_Galaxy_S20_FE_5G_backtrace_us" # --device name="Samsung_Galaxy_S22_Ultra_5G_backtrace_us" From a863421b1b81cf09c98da114f8811966b2a057a7 Mon Sep 17 00:00:00 2001 From: Bartosz Litwiniuk <> Date: Wed, 29 Nov 2023 00:15:45 +0100 Subject: [PATCH 4/4] Use us saucelabs ctl region --- .github/workflows/test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e05eaad4..d3f5ec74 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -102,13 +102,13 @@ jobs: run: | saucectl configure --username ${{ secrets.SAUCE_USERNAME }} --accessKey ${{ secrets.SAUCE_ACCESS_KEY }} # recent real device - saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name="Samsung_Galaxy_S20_FE_5G_backtrace_us" --region eu-central-1 + saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name="Samsung_Galaxy_S20_FE_5G_backtrace_us" --region us-west-1 # newest Android version - saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --emulator name="Android GoogleApi Emulator,platformVersion=12.0" --region eu-central-1 + saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --emulator name="Android GoogleApi Emulator,platformVersion=12.0" --region us-west-1 # oldest Android version - saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --emulator name="Android GoogleApi Emulator,platformVersion=5.1" --region eu-central-1 + saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --emulator name="Android GoogleApi Emulator,platformVersion=5.1" --region us-west-1 # oldest real device (aiming for armv7 / 32bit) - saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name=".*,platformVersion=6.0.1" --region eu-central-1 + saucectl run espresso -c "" --name "From Github Actions" --app example-app-debug.apk --testApp ${{ matrix.test-apk }} --device name=".*,platformVersion=6.0.1" --region us-west-1 # --device name=".*,platformVersion=6.0.1" # --device name="Samsung_Galaxy_S20_FE_5G_backtrace_us" # --device name="Samsung_Galaxy_S22_Ultra_5G_backtrace_us"