[UX] Remove ordering/weight from the vocabularies listing page & style consistently with other admin pages

[jenlampton]

Is this left over from Drupal 6 when they all used to be thrown into the same form element? Does this order / value do anything on Backdrop sites? If not, can we please kill the tabledrag on this page? It's confusing to users.

---

PR by @arjunK2004: backdrop/backdrop#2736
PR by @klonos: backdrop/backdrop#2749
PR by @klnoos (created by jenlampton) backdrop/backdrop#3127
PR by @docwilmot (based on above PR) backdrop/backdrop#3703

[Hipfox]

One of the reason, display taxonomy terms we need taxonomy menu tree order by weight. But in this vocabularies orderable ui when there are a lot of terms, the reordering fails.

Remaining tasks might include a more integrated solution or kill the tabledrag on this page.

[jenlampton]

I'm not talking about terms, but the vocabularies themselves.

[Hipfox]

Yes, I have no reason to keep it.

[klonos]

I don't see any reason either. Drop tabledrag and order alphabetically.

[ak2243]

I created a pr, but I wasn't sure what to replace 'draggable' with so I replaced it with an empty string for now, what should I do now?
backdrop/backdrop#2736

[klonos]

@arjunK2004 we should also remove the weight field from the theme_taxonomy_overview_vocabularies() function, and generally make sure that the "show row weights" link is not rendered at the top-right of the table.

[klonos]

...actually, I don't see why this page should be a form any more if we remove the ordering/weight.

[klonos]

Does this order / value do anything on Backdrop sites?

FTR, this is also being deprecated in D8: https://www.drupal.org/project/drupal/issues/3008064

[jenlampton]

Nice, let's kill the form too :) that might make this no longer a good first issue... But we'll see!

…

On Sat, Jun 15, 2019, 6:40 AM Gregory Netsas ***@***.***> wrote: Does this order / value do anything on Backdrop sites? FTR, this is also being deprecated in D8: https://www.drupal.org/project/drupal/issues/3008064 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2029?email_source=notifications&email_token=AADBER4UWNPCJ4JKV26DLZTP2TWLBA5CNFSM4CKVY3R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYYM3Y#issuecomment-502367855>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBER7CQHD5WUOVJU344YDP2TWLBANCNFSM4CKVY3RQ> .

[klonos]

Yep, @arjunK2004 do you still feel like giving it a crack?

[klonos]

@jenlampton can you please have a look at the comment in https://www.drupal.org/project/drupal/issues/3008064#comment-12824205 and also the use case in https://www.drupal.org/project/drupal/issues/7684 and let me know what you think re these? Are they too "specific"? My concern is that if we completely remove vocabulary weight, we may be breaking people's sites that rely on this functionality; and if the weight of vocabularies is indeed used, we'd be removing the option for people to be able to adjust that via the admin UI.

Having said the above, I have searched for taxonomy_node_get_terms(), and we don't seem to have such a function.

[klonos]

...taxonomy_* functions have been removed on D7:

https://drupal.stackexchange.com/questions/8722/how-do-i-get-a-list-of-all-taxonomy-terms-assigned-to-a-node

https://www.drupal.org/forum/support/post-installation/2010-09-13/taxonomy_node_get_terms-in-drupal-7

So I wonder how one would achieve this (and if it is possible):

...I wanted to force ordering of vocabularies when listing the taxonomies of a node using the taxonomy_link() function. Basically, what I was doing was this: I created a "Story Type" vocab which described the overall type of post ( News, Rant, Review, ... ) and a "Topic" vocab which described the topic of the post ( Programming, Math, Political, Family, ... ). Now, when you added a new story, you picked a Story Type and a Topic. When the story is displayed, it shows the taxonomy assignments as a list of links. The ordering of that list was by term weight, term name. That meant that if I wanted to control the left to right layout of that information, I'd have to set the weight on every term in each vocabulary. That seemed tedious, especially since the vocabularies themselves already had a weight associated with them. Hence, I dug around for about 15 minutes and wrote this patch.

It's been tested and seems to work quite well. I can now force which taxonomy vocabulary is listed when, and thereby always make the posts appear as "Story Type | Topic".

[jenlampton]

@klonos my instinct is that removing these things is still fine for Backdrop, but you do make me hesitate about whether we should do it in 1.x or first deprecate it, but wait till 2.x to do the actual removal.

We've used it to allow customers to change the order of their filter

Theres no information here about what the "filters" are, but from the screenshot, I'd guess they are on a view? Those filters are usually ordered by their position in the views UI, and in order to do do something different we are already in the land of custom-coding, so this is not something that should be supported in core anyway.

Order taxonomy terms by vocabulary weight, then term weight

Hm, this brings up another thought... Do we have a "weight" in the vocabulary json file? If so, should we remove that too? This now becomes an API change. Maybe a follow-up issue? However...

The use-case here would not work in Backdrop anyway because the vocabulary weight is no longer in the database. Someone would need to add special handling to get the vocabulary data from config (its not a db join anymore).

[klonos]

you do make me hesitate about whether we should do it in 1.x or first deprecate it, but wait till 2.x to do the actual removal.

I was thinking that we can deal with the UI bit in this issue here, and do it in 1.x. Then file a follow-up for deprecation/removal of API-related things.

[stpaultim]

Wan't clear if this needed testing. But, I took a look in the sandbox and played around for a bit. Works for me!

[klonos]

Depending on which change gets merged first, either the PR for this issue or for #3402 will need to be updated accordingly.

[klonos]

Thanks for working on this @docwilmot 🙏🏼 ...a couple of minor comments left in the PR, but otherwise looks good 👍🏼

[jenlampton]

The PR looks good to me too, I've left a few comments in the PR as well for a (micro)performance optimization.

[docwilmot]

Fixed

[jenlampton]

This is RTBC from me now, but I expect it will conflict with #3402. Whichever gets in first, the other may need to be updated.

[laryn]

Thanks for filing this @jenlampton, and for the various PRs over the years @docwilmot, @arjunk04, and @klonos. Feedback and testing by all of you and @Hipfox, @BWPanda, and @stpaultim appreciated. Good job closing out an issue from 5+ years ago! 🎉

I've merged backdrop/backdrop#3703 into 1.x and 1.19.x.