Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support signing by ledge for BBN tx #650

Open
jrwbabylonlab opened this issue Jan 27, 2025 · 1 comment
Open

Support signing by ledge for BBN tx #650

jrwbabylonlab opened this issue Jan 27, 2025 · 1 comment
Assignees
@gbarkhatov

Comments

@jrwbabylonlab
Copy link
Collaborator

Image

Ledge does not support the SIGN_MODE_DIRECT which is the default signing method for cosmos nowadays.
We will need to look into the legacy signing mode amino types (e.g go issue cosmos/cosmos-sdk#8136)

The change is likely limited to the bbnRegistry.ts and the signing calling method to decide to use the legacy one if wallet is leger.
Alternatively, we abandon the default and go with legacy. Pending investigation here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbarkhatov gbarkhatov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gbarkhatov @jrwbabylonlab and others