Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded object files from Makefile #48

Open
1 task done
nasbyj opened this issue Dec 7, 2021 · 0 comments
Open
1 task done

Remove hard-coded object files from Makefile #48

nasbyj opened this issue Dec 7, 2021 · 0 comments
Assignees
@shardgupta
Labels
backlog This enhacement is planned to be implemented in the future. build_issues Issues or enhancements related to builds, tests, GH actions etc

Comments

@nasbyj
Copy link
Contributor

nasbyj commented Dec 7, 2021

Contact Details

[email protected]

What happened?

The TSQL make file (and presumably others) hard-codes each .o file into the OBJS variable, which is a maintenance burden. We should replace it with something along the lines of

OBJS = $(patsubst %.c,%.o,$(wildcard src/*.c))

Version

BABEL_1_X_DEV (Default)

Extension

babelfishpg_tsql (Default)

What flavour of Linux are you running into the bug?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nasbyj nasbyj added the bug Something isn't working label Dec 7, 2021
@gopinathpai gopinathpai added the backlog This enhacement is planned to be implemented in the future. label Dec 13, 2021
@suprio-amzn suprio-amzn added build_issues Issues or enhancements related to builds, tests, GH actions etc and removed bug Something isn't working labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shardgupta shardgupta

Labels
backlog This enhacement is planned to be implemented in the future. build_issues Issues or enhancements related to builds, tests, GH actions etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shardgupta @nasbyj @amazon-auto @gopinathpai @suprio-amzn