Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neil add on a dep with :git/sha ends up with both :git/sha and :mvn/version #249

Open
teodorlu opened this issue Dec 31, 2024 · 1 comment

Comments

@teodorlu
Copy link
Contributor

teodorlu commented Dec 31, 2024

System information

$ bb --version 
babashka v1.12.195
$ neil --version
neil 0.3.68
image

Problem

neil add on a dep with :git/sha ends up with both :git/sha and :mvn/version. I don't think that makes sense.

Repro

$ cat deps.edn 
{:paths ["src" "notebooks"]
 :deps {io.github.nextjournal/clerk {:git/sha "285c20ee6bff22a14c7ea2be274d9ac0a37b7668"}}
 :aliases
 {:nextjournal/garden {:exec-fn nextjournal.clerk/serve!
                       :exec-args {:index "notebooks/hello.clj"}}}}
$ neil dep add io.github.nextjournal/clerk
$ cat deps.edn 
{:paths ["src" "notebooks"]
 :deps {io.github.nextjournal/clerk {:git/sha "285c20ee6bff22a14c7ea2be274d9ac0a37b7668"
                                     :mvn/version "0.17.1102"}}
 :aliases
 {:nextjournal/garden {:exec-fn nextjournal.clerk/serve!
                       :exec-args {:index "notebooks/hello.clj"}}}}

Expected behavior

:git/sha is deleted, only the version Neil found remains.

$ cat deps.edn 
{:paths ["src" "notebooks"]
 :deps {io.github.nextjournal/clerk {:mvn/version "0.17.1102"}}
 :aliases
 {:nextjournal/garden {:exec-fn nextjournal.clerk/serve!
                       :exec-args {:index "notebooks/hello.clj"}}}}
@borkdude
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants