Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing footer style and close div tag in contributors.html #3301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akshay0611
Copy link
Contributor

πŸ› οΈ Fixes Issue

Fixes: #3300

πŸ‘¨β€πŸ’» Description

What does this PR do?

This PR addresses the issue related to the footer's copyright section on the contributors.html page. It adds the missing styles to ensure that the copyright text is properly styled and aligned. The changes also ensure visual consistency across the site’s footer sections.

  • The issue was raised due to the missing styling in the copyright section, which caused it to look inconsistent with other pages.
  • The PR improves the alignment and styling, bringing the footer in line with the footer design on other pages, such as blog.html and others.
  • These changes enhance the overall user experience by making the footer appear consistent and professional across all pages.

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • [βœ…] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

(Screenshot 1: Shows the original footer without proper styling and alignment.)

Screenshot 2024-11-18 at 10 32 43 AM

(Screenshot 2: Shows the updated footer with the corrected styling and alignment.)
Screenshot 2024-11-18 at 10 46 34 AM

βœ… Checklist

  • [] I am a participant of GSSoC-ext.
  • [βœ…] I have followed the contribution guidelines of this project.
  • [βœ…] I have made this change on my own.
  • [] I have taken help from some online resources.
  • [βœ…] My code follows the style guidelines of this project.
  • [βœ…] I have performed a self-review of my own code.
  • [βœ…] I have added documentation to explain my changes.

Mandatory Tasks

  • [βœ…] Make sure you have self-reviewed the code. A decent-sized PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
finveda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 18, 2024 5:17am

Copy link

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 18, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit 3668b4c
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/673acdeb2a06910008b510ef
😎 Deploy Preview https://deploy-preview-3301--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 40
Accessibility: 63
Best Practices: 75
SEO: 73
PWA: 50
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[style]: Enhance Footer Consistency for Copyright Section on Contributors Page"
1 participant