-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LensedPS before lensing #53
Comments
Yes! I agree this is needed to have unlensed point source supported here. I think I am in favor of having a single, unified Please go ahead with opening a pull request from a new branch, if you want to have a go at it. That would be great! I propose that we leave the update of the plotting interface to the next step, after converging on the template interface first. |
I created a pull request and will be pushing my updates there soon. |
It should be very easy to extend the LensedPS class in order to account for a non-lensed PS. This will be useful for codes like MOLET and Herculens. I can add this, for example, by adding a "lensed/unlensed" flag to the class (because only a single image can still be there after lensing). Or we could include the unlensed source position and flux as extra but optional arguments to this class.
Of course when it comes to the plotting API, this will mean that we need our own COOLEST way to find the multiple images if only the unlensed source is given. Or not, we can leave this out, and the plots would check this flag and plot the point source accordingly, either on the lens and/or the source planes.
The text was updated successfully, but these errors were encountered: