Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use indexedLines to cache the lineCol-offset correspondence #1301

Closed
ice1000 opened this issue Feb 2, 2025 · 4 comments · Fixed by #1307
Closed

Use indexedLines to cache the lineCol-offset correspondence #1301

ice1000 opened this issue Feb 2, 2025 · 4 comments · Fixed by #1307
Assignees
@linxuanm
Labels
performance

Comments

@ice1000
Copy link
Member

ice1000 commented Feb 2, 2025

Instead of using this shit

Image
@ice1000 ice1000 changed the title Used indexedLines to cache the lineCol-offset correspondence Use indexedLines to cache the lineCol-offset correspondence Feb 2, 2025
@ice1000
Copy link
Member Author

ice1000 commented Feb 2, 2025

aya-dev/tools-kala/src/main/java/org/aya/util/more/StringUtil.java

Line 31 in 7d1ffdc

static @NotNull ImmutableSeq<IntObjTuple2<String>> indexedLines(@NotNull String str) {

@ice1000
Copy link
Member Author

ice1000 commented Feb 2, 2025

Need to refactor that, ofc

@linxuanm linxuanm self-assigned this Feb 6, 2025
@linxuanm
Copy link
Member

linxuanm commented Feb 7, 2025

#1307

@HoshinoTented HoshinoTented linked a pull request Feb 7, 2025 that will close this issue
Fast LineColumn conversion (for #1301) #1307
Merged
@ice1000
Copy link
Member Author

ice1000 commented Feb 7, 2025

#1307

No need to send a reply. GitHub supports linking a branch/PR with an issue

ice1000 added a commit that referenced this issue Feb 7, 2025
@ice1000
merge: Fast LineColumn conversion (for #1301) (#1307)
2275336 
Caches line positions in `SourceFile`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linxuanm linxuanm

Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fast LineColumn conversion (for #1301) aya-prover/aya-dev
2 participants
@ice1000 @linxuanm