Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review eth_estimateGas RPC #1624

Closed
Flouse opened this issue Dec 7, 2023 · 0 comments · Fixed by #1625
Closed

Review eth_estimateGas RPC #1624

Flouse opened this issue Dec 7, 2023 · 0 comments · Fixed by #1625
Assignees
@KaoImin
Labels
d:confirmation Discussion required to confirm whether it's a bug

Comments

@Flouse
Copy link
Contributor

Flouse commented Dec 7, 2023

axon/core/api/src/jsonrpc/impl/web3.rs

Lines 455 to 459 in 02983ed

if let Some(gas_limit) = req.gas.as_ref() {
if gas_limit == &U64::zero() {
return Err(RpcError::GasPriceIsZero.into());
}
}

Maybe use GasLimitIsZero instead of RpcError::GasPriceIsZero here?
@Flouse Flouse added the d:confirmation Discussion required to confirm whether it's a bug label Dec 7, 2023
@Flouse Flouse linked a pull request Dec 7, 2023 that will close this issue
fix: gas limit too low error #1625
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaoImin KaoImin

Labels
d:confirmation Discussion required to confirm whether it's a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: gas limit too low error axonweb3/axon
2 participants
@Flouse @KaoImin