Total difficulty always be zero, but every block difficulty always be one.

[yangby-cryptape]

Current Behavior

Total difficulty always be zero, but every block difficulty always be one.

It doesn't make sense.

axon/protocol/src/types/block.rs

Line 151 in 4cf06e5

difficulty: U256::one(),

axon/core/api/src/jsonrpc/web3_types.rs

Line 322 in 4cf06e5

total_difficulty: Some(U256::zero()),

Same situation (just be constant) for Header.nonce:

axon/core/api/src/jsonrpc/web3_types.rs

Line 337 in 4cf06e5

nonce: H64::default(),

axon/core/api/src/jsonrpc/web3_types.rs

Line 847 in 4cf06e5

nonce: U256::default(),

Expected Behavior

Proposals:

• Should Axon just remove difficulty field from Header?

  Then set Web3Block.difficulty to be constant U256::zero().

• The nonce field in Header is useless, too.

  Should Axon just remove nonce field from Header?

  Then set Web3Block.nonce to be constant U256::zero().

Break changes:

• Block (header) hashes.

Anything else?

The fields difficulty and nonce in Header are used when calculates its hash.

If Axon want to remove them, they have to be removed before release a no-break-changes version.

Ref: #1332 (comment)