Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filterx introduce optimize method #421

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Filterx introduce optimize method #421

wants to merge 6 commits into from

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented Dec 23, 2024

This branch moves the various constructor-time optimizations into a separate method, which has a few advantages:

  1. it is more readable
  2. it becomes optional
  3. memory management is simplified
  4. distinct optimizations steps can cascade to higher level expressions (e.g. a comparison between literals can be promoted into a literal which can then allow optimization for a conditonal as well)

@bazsi bazsi mentioned this pull request Dec 23, 2024
Open
@bazsi bazsi force-pushed the filterx-introduce-optimize-method branch from f28b061 to af26e95 Compare December 28, 2024 06:24
@bazsi bazsi force-pushed the filterx-introduce-optimize-method branch from af26e95 to 79c0cd2 Compare December 28, 2024 06:42
bazsi added 5 commits December 28, 2024 09:35
@bazsi
filterx: add optimize() method for expressions
eb6cc07 
This new method can be used to rewrite the expression tree after parsing
in order to execute faster. This is where we can check literal values
and potentially evaluate literal expressions.

Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi
filterx/expr-boolalg: move optimizations from the constructor to opti…
1cb798e 
…mize()

Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi
filterx/expr-plus: use optimize() method
ec48b4c 
Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi
filterx/expr-comparison: use optimize() method
5daa642 
Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi
filterx/expr-conditional: use optimize()
626a2cf 
Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi bazsi force-pushed the filterx-introduce-optimize-method branch from 79c0cd2 to 626a2cf Compare December 28, 2024 08:41
@bazsi bazsi mentioned this pull request Dec 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bazsi