Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filterx type-aware comparison #320

Open
MrAnno opened this issue Oct 2, 2024 · 0 comments
Open

Fix filterx type-aware comparison #320

MrAnno opened this issue Oct 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@MrAnno
Copy link
Member

MrAnno commented Oct 2, 2024

Type-aware comparison in FilterX is incorrect for non-bultin types (e.g. otel), because we try to convert them to numbers in _evaluate_type_aware() and they end up being NaNs.
We'll probably need a virtual method for comparison.

a = otel_logrecord();
a == a; # false with otel, true with json
@MrAnno MrAnno added the bug Something isn't working label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrAnno