Skip to content

Commit

Permalink
chore: keep old behavior of EccInstructions::sum_with_const
Browse files Browse the repository at this point in the history
After axiom-crypto/halo2-lib#244 the
`EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming
to still use the `sum_unsafe` function so that snark verifier circuits
do not change.
  • Loading branch information
jonathanpwang committed Apr 26, 2024
1 parent 9003c27 commit 2ee2716
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion snark-verifier/src/loader/halo2/shim.rs
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ mod halo2_lib {
let constant = EccInstructions::assign_constant(self, ctx, constant);
Some(constant)
};
self.sum::<C>(
self.sum_unsafe::<C>(
ctx.main(),
constant.into_iter().chain(values.iter().map(|v| v.deref().clone())),
)
Expand Down

0 comments on commit 2ee2716

Please sign in to comment.