Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: safe ecc_sum and tests #244

Merged
merged 6 commits into from
Apr 9, 2024
Merged

feat: safe ecc_sum and tests #244

merged 6 commits into from
Apr 9, 2024

Conversation

MonkeyKing-1
Copy link
Contributor

Wrote a safe version of sum that allows summands to be points at infinity and allows output to be point at infinity

@jonathanpwang
Copy link
Contributor

Lint test is not passing (fix clippy)

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

Added a comment around into_strict and also we can rename the existing sum to unsafe_sum

halo2-ecc/src/ecc/mod.rs Outdated Show resolved Hide resolved
halo2-ecc/src/ecc/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small unnecessary constraint I think.

halo2-ecc/src/ecc/mod.rs Outdated Show resolved Hide resolved
halo2-ecc/src/ecc/mod.rs Outdated Show resolved Hide resolved
halo2-ecc/src/ecc/mod.rs Show resolved Hide resolved
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is a build issue with clap that I will try to resolve.

@jonathanpwang jonathanpwang merged commit d23968c into develop Apr 9, 2024
2 checks passed
@jonathanpwang jonathanpwang deleted the feat/safe_ecc branch April 9, 2024 13:21
jonathanpwang added a commit to axiom-crypto/snark-verifier that referenced this pull request Apr 26, 2024
After axiom-crypto/halo2-lib#244 the
`EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming
to still use the `sum_unsafe` function so that snark verifier circuits
do not change.
jonathanpwang added a commit to axiom-crypto/snark-verifier that referenced this pull request Apr 27, 2024
* chore: keep old behavior of `EccInstructions::sum_with_const`

After axiom-crypto/halo2-lib#244 the
`EccChip::sum` was renamed `EccChip::sum_unsafe`. We update the naming
to still use the `sum_unsafe` function so that snark verifier circuits
do not change.

* chore: fix clap version to prevent rust version issues

* ci: install `svm-rs` with its `Cargo.lock` (#48)

* chore: use solc-select instead of svm to avoid rust version issues

---------

Co-authored-by: Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants