From 2a606ecdb2237cee3eace46ad350e0503e2b1f1c Mon Sep 17 00:00:00 2001 From: Milap Sheth Date: Fri, 10 Jan 2025 10:44:21 -0500 Subject: [PATCH] Apply suggestions from code review --- .changeset/many-tigers-kneel.md | 2 +- contracts/TokenHandler.sol | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.changeset/many-tigers-kneel.md b/.changeset/many-tigers-kneel.md index a17c7f28..0742f1cf 100644 --- a/.changeset/many-tigers-kneel.md +++ b/.changeset/many-tigers-kneel.md @@ -2,4 +2,4 @@ '@axelar-network/interchain-token-service': minor --- -Interchain tokens now get minted/burnt by the token manager. +Interchain tokens now get minted/burnt by the token manager to be consistent with custom tokens diff --git a/contracts/TokenHandler.sol b/contracts/TokenHandler.sol index 244c9d7c..baabe92d 100644 --- a/contracts/TokenHandler.sol +++ b/contracts/TokenHandler.sol @@ -133,8 +133,8 @@ contract TokenHandler is ITokenHandler, ITokenManagerType, ReentrancyGuard, Crea */ // slither-disable-next-line locked-ether function postTokenManagerDeploy(uint256 tokenManagerType, ITokenManager tokenManager) external payable { - // For native interhcain tokens we transfer mintership to the token manager. - // This is done here because InterchainToken bytecode needs to be fixed. + // For native interchain tokens, we transfer mintership to the token manager. + // This is done here because the InterchainToken bytecode is preferred to be fixed to avoid having multiple versions of the Token code used in production. if (tokenManagerType == uint256(TokenManagerType.NATIVE_INTERCHAIN_TOKEN)) { IMinter(tokenManager.tokenAddress()).transferMintership(address(tokenManager)); // For lock/unlock token managers, the ITS contract needs an approval from the token manager to transfer tokens on its behalf.