From 92c776083ee2e220aa569f5b229bb335882dff9c Mon Sep 17 00:00:00 2001
From: Markus Osterlund / robriks <80549215+robriks@users.noreply.github.com>
Date: Tue, 6 Aug 2024 19:08:58 -0400
Subject: [PATCH] Network.ts - script hangs when reassigning w/
 ContractFactory::deploy

Local bridging script hangs indefinitely while waiting for the `InterchainTokenFactoryContract` deployment.

This is likely due to the fact that the `ethersJS::Contract::deployed()` method is invoked twice for the same variable, `implementation`.  EthersJS seems to get confused when using
`let implementation = await deployContract(<InterchainTokenServiceContract>)`
and then reassigning like so:
`implementation = await deployContract(<InterchainTokenFactoryContract>)`
since `deployContract()` calls `await contract.deployed()`

Using a single const variable for each contract returned by `deployContract()` resolved the issue, as made in this PR
---
 packages/axelar-local-dev/src/Network.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/axelar-local-dev/src/Network.ts b/packages/axelar-local-dev/src/Network.ts
index 6bcf30e2..481aa768 100644
--- a/packages/axelar-local-dev/src/Network.ts
+++ b/packages/axelar-local-dev/src/Network.ts
@@ -238,7 +238,7 @@ export class Network {
         const tokenHandler = await deployContract(wallet, TokenHandler, []);
         const interchainTokenFactoryAddress = await this.create3Deployer.deployedAddress('0x', wallet.address, factorySalt);
 
-        let implementation = await deployContract(wallet, InterchainTokenServiceContract, [
+        const tokenServiceImplementation = await deployContract(wallet, InterchainTokenServiceContract, [
             tokenManagerDeployer.address,
             interchainTokenDeployer.address,
             this.gateway.address,
@@ -250,16 +250,16 @@ export class Network {
         ]);
         const factory = new ContractFactory(InterchainProxy.abi, InterchainProxy.bytecode);
         let bytecode = factory.getDeployTransaction(
-            implementation.address,
+            tokenServiceImplementation.address,
             wallet.address,
             defaultAbiCoder.encode(['address', 'string', 'string[]', 'string[]'], [wallet.address, this.name, [], []])
         ).data;
         await this.create3Deployer.connect(wallet).deploy(bytecode, deploymentSalt);
         this.interchainTokenService = InterchainTokenServiceFactory.connect(interchainTokenServiceAddress, wallet);
 
-        implementation = await deployContract(wallet, InterchainTokenFactoryContract, [interchainTokenServiceAddress]);
+        const tokenFactoryImplementation = await deployContract(wallet, InterchainTokenFactoryContract, [interchainTokenServiceAddress]);
 
-        bytecode = factory.getDeployTransaction(implementation.address, wallet.address, '0x').data;
+        bytecode = factory.getDeployTransaction(tokenFactoryImplementation.address, wallet.address, '0x').data;
 
         await this.create3Deployer.connect(wallet).deploy(bytecode, factorySalt);
         this.interchainTokenFactory = InterchainTokenFactoryFactory.connect(interchainTokenFactoryAddress, wallet);