Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

enable hot reload #2

Open
Blueforcer opened this issue Jan 11, 2021 · 2 comments
Open

enable hot reload #2

Blueforcer opened this issue Jan 11, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Blueforcer
Copy link
Member

For Apps and Core

@Blueforcer Blueforcer added the enhancement New feature or request label Jan 11, 2021
@padarom
Copy link

padarom commented Jan 11, 2021

Hot Reload for the Core should already work as that is just the default Nuxt feature. The core needs to be started in dev mode though, which I think can be done with npm run dev.

padarom pushed a commit that referenced this issue Jan 11, 2021
@padarom
Copy link

padarom commented Jan 11, 2021

I implemented it for now as a live reload, rather than a hot reload. Hot reload would require module replacement, i.e. redefining functions that have changed since the last version. Since we are using the Vue CLI service to build apps to a UMD file, I am quite sure we can't currently get HMR changelogs, meaning I'd have to implement HMR myself, which I think is a bit above the scope of this as of right now. I'd still prefer hot reloading, but I think live reload is just a minor inconvenience in the grand scheme of things and we can try to get at proper HMR in the future.

See https://stackoverflow.com/a/24587740/3025537 as a reference to what I'm talking about.

padarom pushed a commit that referenced this issue Jan 11, 2021
padarom pushed a commit that referenced this issue Jan 11, 2021
@padarom padarom mentioned this issue Apr 6, 2021
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants