diff --git a/CHANGELOG.md b/CHANGELOG.md index d3d64e87..4c0933b8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a Ch ### Fixes - corecting urllib hard dependency version +- global and regional param resolution should usse account_alias instead of account_id ## v2.10.3 (2023-09-22) diff --git a/seedfarmer/commands/_parameter_commands.py b/seedfarmer/commands/_parameter_commands.py index 00bed078..21eca2ee 100644 --- a/seedfarmer/commands/_parameter_commands.py +++ b/seedfarmer/commands/_parameter_commands.py @@ -97,7 +97,7 @@ def load_parameter_values( ) elif parameter.value_from.parameter_value: p_value = deployment_manifest.get_parameter_value( - parameter=parameter.value_from.parameter_value, account_id=target_account, region=target_region + parameter=parameter.value_from.parameter_value, account_alias=target_account, region=target_region ) if p_value is not None: p_value = str(p_value) if isinstance(p_value, str) else json.dumps(p_value) diff --git a/test/unit-test/test_commands_parameters.py b/test/unit-test/test_commands_parameters.py index f7a18180..0308fd13 100644 --- a/test/unit-test/test_commands_parameters.py +++ b/test/unit-test/test_commands_parameters.py @@ -196,7 +196,7 @@ def test_load_parameter_values(session_manager, mocker): deployment_name="mlops", deployment_manifest=dep, parameters=dep.groups[1].modules[0].parameters, - target_account="123456789012", + target_account="primary", target_region="us-east-1", ) names = []