Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: discrepancy between [Tool, Tools] and [AgentTool, AgentTools] #202

Open
j-beniwal opened this issue Jan 11, 2025 · 3 comments
Open
Labels
bug Something isn't working triage

Comments

@j-beniwal
Copy link

Expected Behaviour

As pointed out in all the examples the below code should work

from multi_agent_orchestrator.utils import AgentTools, AgentTool,

Current Behaviour

But when I go to the utils folder and see below is the code.

`"""Module for importing helper functions and Logger."""
from .helpers import is_tool_input, conversation_to_dict
from .logger import Logger
from .tool import Tool, Tools

all = [
'is_tool_input',
'conversation_to_dict',
'Logger',
'Tool',
'Tools',
]
`

I am running on multi_agent_orchestrator 0.1.4.

I checked out the main branch and found below code in utils

Code snippet

from multi_agent_orchestrator.utils import AgentTools, AgentTool

create_appointment_tool = AgentTool(
    name="blaaabla",
    description="bla bla bla",
    properties = {
        "bl": {
            "type" : "string",
            "description" : "blabla"
        },
        "appointment_details": {
            "type" : CreateAppointment,
            "description": "blabla [ bl]"
        }
    },
    func=blalllll,
    # Note: add output formatter 
    # enum_values = [{}]
    
)

Possible Solution

Don't do this please please please.

Steps to Reproduce

it runs on the main branch but not on your last python release.

@j-beniwal j-beniwal added the bug Something isn't working label Jan 11, 2025
@j-beniwal
Copy link
Author

Screenshot 2025-01-11 at 2 47 50 PM [Anthony Bernabeu] Please

@j-beniwal j-beniwal changed the title Bug: descripency between [tool, tools] and [AgentTool, AgentTools] Bug: discrepancy between [Tool, Tools] and [AgentTool, AgentTools] Jan 11, 2025
@cornelcroi
Copy link
Contributor

Hi,
I think you may use a version where this feature was not released yet.
The current version is v0.1.6.
Also, the code in tools utils folder is (which is correct)

"""Module for importing helper functions and Logger."""
from .helpers import is_tool_input, conversation_to_dict
from .logger import Logger
from .tool import AgentTool, AgentTools

__all__ = [
    'is_tool_input',
    'conversation_to_dict',
    'Logger',
    'AgentTool',
    'AgentTools',
]

Can you check again?

@j-beniwal
Copy link
Author

Screenshot 2025-01-12 at 9 27 05 AM

I see Yesterday there was a release made for python v0.1.6

Let me try with the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants