Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default logging level from WARN to INFO #1244

Open
dannycjones opened this issue Jan 24, 2025 · 0 comments
Open

Update default logging level from WARN to INFO #1244

dannycjones opened this issue Jan 24, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dannycjones
Copy link
Contributor

Today, Mountpoint uses WARN logging by default (and also disabled CRT logging entirely as it is noisy for our use case).

/// Generates a logging configuration based on the CLI arguments.
///
/// This includes random string generation which can change with each invocation,
/// so once created the [LoggingConfig] should be cloned if another owned copy is required.
fn make_logging_config(&self) -> LoggingConfig {
let default_filter = if self.no_log {
String::from("off")
} else {
let mut filter = if self.debug {
String::from("debug")
} else {
String::from("warn")
};
let crt_verbosity = if self.debug_crt { "debug" } else { "off" };
filter.push_str(&format!(",{}={}", AWSCRT_LOG_TARGET, crt_verbosity));
if self.log_metrics {
filter.push_str(&format!(",{}=info", metrics::TARGET_NAME));
}
filter
};
let log_file = self.log_directory.as_ref().map(|dir| prepare_log_file_name(dir));
LoggingConfig {
log_file,
log_to_stdout: self.foreground,
default_filter,
}
}

Instead, we should have INFO logging by default so that that you can see messages such as when the mount occurred successfully and where, even where users may capture logs without --debug specified.

This isn't as simple as changing one line of code. For this issue, we should review where we perform INFO logging in Mountpoint, and downgrade or adjust if necessary. For example, we should ensure that metric logging is turned off or downgraded when the customer does not specify --log-metrics.

@dannycjones dannycjones added enhancement New feature or request good first issue Good for newcomers labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant