Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Nagle #19

Open
aajtodd opened this issue Jul 18, 2024 · 1 comment
Open

Disable Nagle #19

aajtodd opened this issue Jul 18, 2024 · 1 comment
Labels
optimization Optimization to explore

Comments

@aajtodd
Copy link
Contributor

aajtodd commented Jul 18, 2024

Disable nagle's algorithm on HTTP connector.

@aajtodd aajtodd added the optimization Optimization to explore label Jul 18, 2024
@waahm7
Copy link
Contributor

waahm7 commented Oct 14, 2024

I have done an initial benchmark run with current state of things:

With NO_DELAY:
download-30GiB-1x-ram.run.json with 125 concurrency:
Run:1 Secs:9.108783 Gb/s:28.291161
Run:2 Secs:6.520921 Gb/s:39.518654
Run:3 Secs:6.602142 Gb/s:39.032488
Run:4 Secs:3.359281 Gb/s:76.712259
Run:5 Secs:3.237221 Gb/s:79.604712
Run:6 Secs:3.324450 Gb/s:77.516001
Run:7 Secs:3.624865 Gb/s:71.091766
Run:8 Secs:7.736387 Gb/s:33.309870
Run:9 Secs:3.590431 Gb/s:71.773570
Run:10 Secs:3.597755 Gb/s:71.627454

Default:
download-30GiB-1x-ram.run.json with 125 concurrency:
Run:1 Secs:8.816590 Gb/s:29.228766
Run:2 Secs:7.552424 Gb/s:34.121235
Run:3 Secs:3.498080 Gb/s:73.668416
Run:4 Secs:3.480027 Gb/s:74.050578
Run:5 Secs:3.431864 Gb/s:75.089825
Run:6 Secs:3.438130 Gb/s:74.952954
Run:7 Secs:3.521958 Gb/s:73.168968
Run:8 Secs:3.375376 Gb/s:76.346469
Run:9 Secs:3.304250 Gb/s:77.989873
Run:10 Secs:4.530187 Gb/s:56.884632

Just sharing the numbers: we do see a slight improvement in some runs. This might be worth revisiting later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Optimization to explore
Projects
None yet
Development

No branches or pull requests

2 participants