Skip to content

Commit 02ecf22

Browse files
lavaleriacioc
andauthored
Apply suggestions from code review
Co-authored-by: Alex Cioc <[email protected]>
1 parent 35c4b7e commit 02ecf22

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

proposals/2020-07-28_keyring-cmm/proposal.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ in this document are to be interpreted as described in
4242

4343
## Summary
4444

45-
The Default CMM is an implementation of the CMM interface that serves a majority of use cases,
45+
The Default Cryptographic Materials Manager (CMM) is an implementation of the CMM interface that serves a majority of use cases,
4646
using [keyrings](../../framework/keyring-interface.md) or
4747
[master key providers](../../framework/master-key-provider-interface.md) to get and
4848
decrypt materials.
@@ -134,10 +134,10 @@ The specific CMM configuration describes a
134134
that serves most use cases.
135135

136136
The CMM configuration defined by the Default CMM is the [Keyring CMM](#keyring-cmm) as is
137-
(The Keyring CMM provides no additional options other than specifying an underlying Keyring).
137+
(the Keyring CMM provides no additional options other than specifying an underlying keyring).
138138

139139
As the AWS Encryption SDK provides more CMM implementations that would benefit default use cases,
140-
we expect to update the Default CMM to a configuration which composes such CMMs together provide
140+
we expect to update the Default CMM to a configuration which composes such CMMs together in order to provide
141141
useful properties.
142142
Any update to the composition defined by Default CMM SHOULD be backwards compatable.
143143

@@ -181,7 +181,7 @@ SHOULD compose with the Master Key Provider CMM.
181181
On initialization, the caller MUST provide exactly one of the following:
182182

183183
- [Keyring](../../framework/keyring-interface.md)
184-
- If this AWS Encryption SDK implementations provides a [Master Key Provider CMM](#master-key-provider-cmm),
184+
- If this AWS Encryption SDK implementation provides a [Master Key Provider CMM](#master-key-provider-cmm),
185185
a [Master Key Provider](../../framework/master-key-provider-interface.md)
186186

187187
The Default CMM MUST NOT accept any additional configuration.
@@ -204,6 +204,6 @@ Default CMM prior to this change.
204204

205205
### Master Key Provider CMM
206206

207-
The specification of the Master Key Provider CMM MUST be the specification of
208-
the Default CMM, except describing use of a master key provider instead of a keyring
207+
The specification of the Master Key Provider CMM MUST be the specification of the Default CMM,
208+
except describing the use of a master key provider instead of a keyring
209209
where appropriate.

0 commit comments

Comments
 (0)