Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the text disappears when translating #4

Open
AJStacy opened this issue Dec 30, 2021 · 1 comment
Open

Some of the text disappears when translating #4

AJStacy opened this issue Dec 30, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@AJStacy
Copy link
Contributor

AJStacy commented Dec 30, 2021

Occasionally when a page is translated some of the text will become blank. This could be due to an incorrect response from Amazon Translate or an error when parsing the response.

If a response is returned blank or the parsing function returns an empty result we should not replace the text in the associated text node in the DOM.
@AJStacy AJStacy added the bug Something isn't working label Dec 30, 2021
@s-gazda
Copy link

s-gazda commented Mar 1, 2022

Parts of the text often disappear after ":" For example "Fodera: Sintetico" (which translate as "Lining: Synthetic") gets translated as "Lining" only (e.g. https://www.amazon.it/dp/B08NCPT7YP)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AJStacy @s-gazda