Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycling old, unused files #175

Open
ChaiBapchya opened this issue Jun 11, 2020 · 4 comments
Open

Recycling old, unused files #175

ChaiBapchya opened this issue Jun 11, 2020 · 4 comments
Labels
type: enhancement New feature or request

Comments

@ChaiBapchya
Copy link
Contributor

Since the dockerfiles, tests have been migrated to https://github.com/aws/deep-learning-containers

We should clean up the redundant [and hence confusing] files such as

  • Dockerfiles
  • test/
@ChaiBapchya
Copy link
Contributor Author

@saimidu FYI

@saimidu
Copy link
Contributor

saimidu commented Jun 11, 2020

Thanks @ChaiBapchya. All the redundant files will be deleted as soon as the migration of the dockerfiles for older framework versions is complete. Thank you for raising this issue.

@chuyang-deng
Copy link
Contributor

Hi @ChaiBapchya, we will remove the DLC docker images once all existing container versions are migrated.

@chuyang-deng chuyang-deng added the type: enhancement New feature or request label Jun 11, 2020
@nadiaya
Copy link
Contributor

nadiaya commented Jun 11, 2020

Hi,

We are still in the process of migration/separation plan of DLC and sagemaker toolkits that has been happening in the last few months.

We already cleaned up tests 10 days ago:
4a647a9

And, as part of the plan, will be keeping dockerfiles until all of them are fully migrated to the dlc repo. They have been put in read only mode and changes to the dockerfiles are no longer accepted on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants