refactor: add libcrypto PRF impl for openssl-3.0-fips #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
openssl3fips_prf
branch
from
8201d5c to
206fdfa
Compare
lrstewart
force-pushed
the
openssl3fips_prf
branch
from
206fdfa to
302ce4a
Compare
lrstewart
commented
Mar 2, 2025
Comment on lines
+23
to
+25
| #if defined(OPENSSL_IS_AWSLC) | ||
|
|
||
| /* The AWSLC TLS PRF API is exported in all AWSLC versions. However, in the AWSLC FIPS branch, this |
There was a problem hiding this comment.
I didn't modify any of the AWSLC PRF code. I just moved it.
dougch
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #5143
Description of changes:
Add a new libcrypto PRF using openssl-3.0's EVP_KDF methods and "EVP_KDF-TLS1_PRF" algorithm:
https://docs.openssl.org/3.4/man3/EVP_KDF/
https://docs.openssl.org/3.4/man7/EVP_KDF-TLS1_PRF/
I also moved the libcrypto PRFs to a separate file. I think it belongs in the crypto folder?
Testing:
I mostly reused the existing tests, but with some improvements to make them more useful:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.