From cdb7ae4ca7590257c1255574cd30f7202214faad Mon Sep 17 00:00:00 2001 From: Jou Ho <43765840+jouho@users.noreply.github.com> Date: Mon, 8 Jul 2024 16:47:56 -0700 Subject: [PATCH 1/2] refactor: use feature probe for AEAD gate logic instead of AWS-LC/BoringSSL macros (#4642) --- crypto/s2n_aead_cipher_aes_gcm.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/crypto/s2n_aead_cipher_aes_gcm.c b/crypto/s2n_aead_cipher_aes_gcm.c index 6fea5a30080..2d28473a443 100644 --- a/crypto/s2n_aead_cipher_aes_gcm.c +++ b/crypto/s2n_aead_cipher_aes_gcm.c @@ -22,13 +22,9 @@ #include "utils/s2n_blob.h" #include "utils/s2n_safety.h" -#if defined(OPENSSL_IS_BORINGSSL) || defined(OPENSSL_IS_AWSLC) - #define S2N_AEAD_AES_GCM_AVAILABLE -#endif - static uint8_t s2n_aead_cipher_aes128_gcm_available() { -#if defined(S2N_AEAD_AES_GCM_AVAILABLE) +#if defined(S2N_LIBCRYPTO_SUPPORTS_EVP_AEAD_TLS) return (EVP_aead_aes_128_gcm() ? 1 : 0); #else return (EVP_aes_128_gcm() ? 1 : 0); @@ -37,14 +33,14 @@ static uint8_t s2n_aead_cipher_aes128_gcm_available() static uint8_t s2n_aead_cipher_aes256_gcm_available() { -#if defined(S2N_AEAD_AES_GCM_AVAILABLE) +#if defined(S2N_LIBCRYPTO_SUPPORTS_EVP_AEAD_TLS) return (EVP_aead_aes_256_gcm() ? 1 : 0); #else return (EVP_aes_256_gcm() ? 1 : 0); #endif } -#if defined(S2N_AEAD_AES_GCM_AVAILABLE) /* BoringSSL and AWS-LC AEAD API implementation */ +#if defined(S2N_LIBCRYPTO_SUPPORTS_EVP_AEAD_TLS) /* BoringSSL and AWS-LC AEAD API implementation */ static int s2n_aead_cipher_aes_gcm_encrypt(struct s2n_session_key *key, struct s2n_blob *iv, struct s2n_blob *aad, struct s2n_blob *in, struct s2n_blob *out) { From 9371c90f3852db19429875e2d9a553d87aff9301 Mon Sep 17 00:00:00 2001 From: Doug Chapman <54039637+dougch@users.noreply.github.com> Date: Mon, 8 Jul 2024 19:15:43 -0700 Subject: [PATCH 2/2] ci(nix): Add tshark to nix devshell (#4571) --- flake.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/flake.nix b/flake.nix index 2fca3a7d3b3..3f2bdd1c0f8 100644 --- a/flake.nix +++ b/flake.nix @@ -32,6 +32,7 @@ # GnuTLS-cli and serv utilities needed for some integration tests. pkgs.gnutls pkgs.gdb + pkgs.tshark # C Compiler Tooling: llvmPkgs.clangUseLLVM -- wrapper to overwrite default compiler with clang llvmPkgs.llvm