feat: emit migration deny reason with datagram drop event #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/datagram-drop-reason
branch
from
408549a to
9348317
Compare
camshaft
force-pushed
the
camshaft/datagram-drop-reason
branch
from
9348317 to
02574ef
Compare
|
|
||
| let datagram_dropped_events = datagram_dropped_events.lock().unwrap(); | ||
|
|
||
| for event in datagram_dropped_events.iter() { |
There was a problem hiding this comment.
Maybe add an assertion on the length of datagram_dropped_events so we catch if no events are emitted
WesleyRosenblum
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change expand the DataDroppedReason to include the expanded MigrationDenyReason, which would explain more specifically why a connection migration was denied, not just that it was denied.
Testing:
I added an integration test that shows the new
reasonfield being returned as expected.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.