From 26472528c09317c44c8a1abd23a9be1a0f4e80ed Mon Sep 17 00:00:00 2001 From: Boquan Fang Date: Tue, 10 Dec 2024 22:59:41 +0000 Subject: [PATCH] address PR comments --- .github/workflows/ci.yml | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ff482ac5c..5dc0a69ed 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,6 @@ env: # Pin the nightly toolchain to prevent breakage. # This should be occasionally updated. RUST_NIGHTLY_TOOLCHAIN: nightly-2024-12-01 - ROOT_PATH: . CDN: https://dnglbrstg7yg.cloudfront.net # enable unstable features for testing S2N_UNSTABLE_CRYPTO_OPT_TX: 100 @@ -224,6 +223,10 @@ jobs: os: ubuntu-latest target: native env: S2N_QUIC_PLATFORM_FEATURES_OVERRIDE="mtu_disc,pktinfo,tos,socket_msg" >> $GITHUB_ENV; echo S2N_QUIC_RUN_VERSION_SPECIFIC_TESTS=1 + - rust: ${{ env.RUST_NIGHTLY_TOOLCHAIN }} + os: ubuntu-latest + env: RUSTFLAGS="-Zsanitizer=address" RUSTDOCFLAGS="-Zsanitizer=address" + args: -Zbuild-std steps: - uses: ilammy/setup-nasm@v1 - uses: actions/checkout@v4 @@ -272,23 +275,6 @@ jobs: run: | ${{ matrix.target != 'native' && 'cross' || 'cargo' }} test --workspace ${{ matrix.exclude }} ${{ matrix.target != 'native' && format('--target {0}', matrix.target) || '' }} ${{ matrix.args }} - - name: Install Nightly toolchain - id: toolchain - run: | - rustup toolchain install ${{ env.RUST_NIGHTLY_TOOLCHAIN }} --profile minimal - rustup override set ${{ env.RUST_NIGHTLY_TOOLCHAIN }} - - - name: Run Unit Tests under ASAN - env: - RUSTDOCFLAGS: -Zsanitizer=address - RUSTFLAGS: -Zsanitizer=address - run: | - sudo ln -s $(find /usr/bin/ -maxdepth 1 -name "llvm-symbolizer-*" | sort -V | tail -n 1) /usr/bin/llvm-symbolizer - cargo test \ - -Zbuild-std \ - --manifest-path ${{ env.ROOT_PATH}}/Cargo.toml \ - --target x86_64-unknown-linux-gnu - fips: runs-on: ubuntu-latest steps: