Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fasthttp.Client #360

Open
joanlopez opened this issue Apr 26, 2022 · 2 comments
Open

Support for fasthttp.Client #360

joanlopez opened this issue Apr 26, 2022 · 2 comments

Comments

@joanlopez
Copy link

Background

fasthttp is an alternative to Go's native net/http network library. It is written to be significantly more performant at scale; in some cases, it is ~10x faster than the standard library. It is used widely and is well-maintained.

Moreover, this project already have support for fasthttp handlers: issue & merged pull request.

The Ask

Therefore, it'd be helpful if aws-xray-sdk-go could work out-of-the-box with fasthttp client as well.
The client implementation is different enough to make it not trivial to use as-is.

Links

fasthttp
net/http-->fasthttp request adaptor

@willarmiros
Copy link
Contributor

willarmiros commented May 3, 2022

Hi @joanlopez - thanks for the feedback! We'd be happy to take a look at a PR for a new client instrumentation, however at this time we will not be able to add new instrumentations on our roadmap.

Alternatively, we would recommend you check out the AWS Distro for OpenTelemetry Go, which provides first-class fasthttp support and support for the X-Ray backend! https://aws-otel.github.io/docs/getting-started/go-sdk

We are always open to feedback that you can open here: https://github.com/aws-observability/aws-otel-go

@joanlopez
Copy link
Author

Alternatively, we would recommend you check out the AWS Distro for OpenTelemetry Go, which provides first-class fasthttp support and support for the X-Ray backend! https://aws-otel.github.io/docs/getting-started/go-sdk

Sure, sounds like a great alternative! :) Could you please point out to any code example / documentation page with examples or information about how to instrumentate the SDK with the fasthtt, please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants