From b2969ff232c4d398be4df7b69bdd87e6e12fa295 Mon Sep 17 00:00:00 2001
From: Nikolas Komonen <118216176+nkomonen-amazon@users.noreply.github.com>
Date: Wed, 17 Apr 2024 17:04:44 -0400
Subject: [PATCH] update to require problem matcher extension (#4729)

When we build locally this problem matcher helps the IDE detect that
a webpack watch execution is finished so that the build scripts
can progress.

Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>
---
 .vscode/extensions.json                  | 3 +++
 CONTRIBUTING.md                          | 3 ++-
 packages/amazonq/.vscode/extensions.json | 5 -----
 packages/core/.vscode/extensions.json    | 5 -----
 packages/toolkit/.vscode/extensions.json | 5 -----
 5 files changed, 5 insertions(+), 16 deletions(-)
 create mode 100644 .vscode/extensions.json
 delete mode 100644 packages/amazonq/.vscode/extensions.json
 delete mode 100644 packages/core/.vscode/extensions.json
 delete mode 100644 packages/toolkit/.vscode/extensions.json

diff --git a/.vscode/extensions.json b/.vscode/extensions.json
new file mode 100644
index 00000000000..c5faaa009d6
--- /dev/null
+++ b/.vscode/extensions.json
@@ -0,0 +1,3 @@
+{
+    "recommendations": ["amodio.tsl-problem-matcher", "dbaeumer.vscode-eslint"]
+}
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 358eb4860fa..51eba829681 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -29,7 +29,8 @@ To develop this project, install these dependencies:
 -   [Git](https://git-scm.com/downloads)
     -   (optional) Set `git blame` to ignore noise-commits: `git config blame.ignoreRevsFile .git-blame-ignore-revs`
 -   [AWS `git secrets`](https://github.com/awslabs/git-secrets)
--   (required for Web mode) [TypeScript + Webpack Problem Matcher](https://marketplace.visualstudio.com/items?itemName=amodio.tsl-problem-matcher)
+-   [TypeScript + Webpack Problem Matcher](https://marketplace.visualstudio.com/items?itemName=amodio.tsl-problem-matcher)
+    -   Not installing will result in the following error during building: `Error: Invalid problemMatcher reference: $ts-webpack-watch`
 -   (optional) [AWS SAM CLI](https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-install.html)
 -   (optional) [Docker](https://docs.docker.com/get-docker/)
 
diff --git a/packages/amazonq/.vscode/extensions.json b/packages/amazonq/.vscode/extensions.json
deleted file mode 100644
index b1a2d99f09e..00000000000
--- a/packages/amazonq/.vscode/extensions.json
+++ /dev/null
@@ -1,5 +0,0 @@
-{
-    // See http://go.microsoft.com/fwlink/?LinkId=827846
-    // for the documentation about the extensions.json format
-    "recommendations": ["dbaeumer.vscode-eslint"]
-}
diff --git a/packages/core/.vscode/extensions.json b/packages/core/.vscode/extensions.json
deleted file mode 100644
index b1a2d99f09e..00000000000
--- a/packages/core/.vscode/extensions.json
+++ /dev/null
@@ -1,5 +0,0 @@
-{
-    // See http://go.microsoft.com/fwlink/?LinkId=827846
-    // for the documentation about the extensions.json format
-    "recommendations": ["dbaeumer.vscode-eslint"]
-}
diff --git a/packages/toolkit/.vscode/extensions.json b/packages/toolkit/.vscode/extensions.json
deleted file mode 100644
index b1a2d99f09e..00000000000
--- a/packages/toolkit/.vscode/extensions.json
+++ /dev/null
@@ -1,5 +0,0 @@
-{
-    // See http://go.microsoft.com/fwlink/?LinkId=827846
-    // for the documentation about the extensions.json format
-    "recommendations": ["dbaeumer.vscode-eslint"]
-}