diff --git a/.eslintrc.js b/.eslintrc.js index 34ab1d2c0a1..2daaa9191af 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -70,10 +70,10 @@ module.exports = { '@typescript-eslint/no-explicit-any': 'off', // TODO rennable this rule (by removing this off) '@typescript-eslint/explicit-function-return-type': 'off', - // TODO rennable this rule (by removing this off) - 'no-null/no-null': 'off', // TODO reenable this rule, tests mostly break this one (by changing off to error) + // This currently produces 700 non fixable by --fix errors 'sort-imports': 'off', + 'no-null/no-null': 'error', '@typescript-eslint/no-empty-function': 'off', '@typescript-eslint/no-unused-vars': 'off', // Do not check loops so while(true) works. Potentially reevalute this. diff --git a/src/test/shared/clients/fakeFileStreams.ts b/src/test/shared/clients/fakeFileStreams.ts index d481dc99dc0..61638000f73 100644 --- a/src/test/shared/clients/fakeFileStreams.ts +++ b/src/test/shared/clients/fakeFileStreams.ts @@ -33,6 +33,8 @@ export class FakeFileStreams implements FileStreams { objectMode: true, read() { this.push(readData) + // MUST be null or else it will not stop reading + // eslint-disable-next-line no-null/no-null this.push(null) }, }) @@ -64,6 +66,8 @@ export class FakeFileStreams implements FileStreams { objectMode: true, read() { this.push(data) + // MUST be null or else it will not stop reading + // eslint-disable-next-line no-null/no-null this.push(null) }, })