8.3 support (#2867)

Author: stobrien89

.changes/nextrelease/8_3-support.json

@@ -0,0 +1,7 @@
+[
+  {
+    "type": "feature",
+    "category": "",
+    "description": "Adds support for the PHP 8.3 runtime"
+  }
+]

.github/workflows/tests.yml

@@ -34,7 +34,7 @@ jobs:
     strategy:
       #for each of the following versions of PHP, with and without --prefer-lowest
       matrix:
-        php-versions: ['7.2.5', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
+        php-versions: ['7.2.5', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
         composer-options: ['', '--prefer-lowest']
     #set the name for each job
     name: PHP ${{ matrix.php-versions }} ${{ matrix.composer-options }}

src/Crypto/AesGcmDecryptingStream.php

@@ -29,6 +29,11 @@ class AesGcmDecryptingStream implements AesStreamInterface
 
     private $tagLength;
 
+    /**
+     * @var StreamInterface
+     */
+    private $stream;
+
     /**
      * @param StreamInterface $cipherText
      * @param string $key
@@ -54,6 +59,9 @@ public function __construct(
         $this->aad = $aad;
         $this->tagLength = $tagLength;
         $this->keySize = $keySize;
+        // unsetting the property forces the first access to go through
+        // __get().
+        unset($this->stream);
     }
 
     public function getOpenSslName()

src/Crypto/AesGcmEncryptingStream.php

@@ -29,6 +29,11 @@ class AesGcmEncryptingStream implements AesStreamInterface, AesStreamInterfaceV2
 
     private $tagLength;
 
+    /**
+     * @var StreamInterface
+     */
+    private $stream;
+
     /**
      * Same as non-static 'getAesName' method, allowing calls in a static
      * context.
@@ -63,6 +68,9 @@ public function __construct(
         $this->aad = $aad;
         $this->tagLength = $tagLength;
         $this->keySize = $keySize;
+        // unsetting the property forces the first access to go through
+        // __get().
+        unset($this->stream);
     }
 
     public function getOpenSslName()

src/PresignUrlMiddleware.php

@@ -59,7 +59,7 @@ public static function wrap(
     public function __invoke(CommandInterface $cmd, RequestInterface $request = null)
     {
         if (in_array($cmd->getName(), $this->commandPool)
-            && (!isset($cmd->{'__skip' . $cmd->getName()}))
+            && (!isset($cmd['__skip' . $cmd->getName()]))
         ) {
             $cmd['DestinationRegion'] = $this->client->getRegion();
             if (!empty($cmd['SourceRegion']) && !empty($cmd[$this->presignParam])) {
@@ -84,7 +84,7 @@ private function createPresignedUrl(
         $cmdName = $cmd->getName();
         $newCmd = $client->getCommand($cmdName, $cmd->toArray());
         // Avoid infinite recursion by flagging the new command.
-        $newCmd->{'__skip' . $cmdName} = true;
+        $newCmd['__skip' . $cmdName] = true;
 
         // Serialize a request for the operation.
         $request = \Aws\serialize($newCmd);

tests/AbstractConfigurationProviderTest.php

@@ -80,7 +80,7 @@ public function testsPersistsToCache()
         $ref = new \ReflectionClass('\Aws\AbstractConfigurationProvider');
         $property = $ref->getProperty('interfaceClass');
         $property->setAccessible(true);
-        $property->setValue('\Aws\ResultInterface');
+        $property->setValue(null,'\Aws\ResultInterface');
 
         $timesCalled = 0;
         $volatileProvider = function () use ($expected, &$timesCalled) {

tests/EndpointDiscovery/EndpointDiscoveryMiddlewareTest.php

@@ -662,7 +662,7 @@ public function testCallsDiscoveryApiOnInvalidEndpointException($exception)
             'discoveryCooldown'
         );
         $reflection->setAccessible(true);
-        $reflection->setValue(0);
+        $reflection->setValue(null, 0);
         $callOrder = [];
         $handler = function (
             CommandInterface $cmd,
@@ -672,7 +672,7 @@ public function testCallsDiscoveryApiOnInvalidEndpointException($exception)
                 // On the second trip to DescribeEndpoints, can set discoveryCooldown
                 // back to 60, allowing failure to occur naturally on next pass
                 if (in_array('describe', $callOrder)) {
-                    $reflection->setValue(60);
+                    $reflection->setValue(null, 60);
                 }
                 $callOrder[] = 'describe';
                 return $this->generateSingleDescribeResult();

tests/QueryCompatibleInputMiddlewareTest.php

@@ -26,7 +26,7 @@ public function testEmitsWarning($inputParam, $inputValue, $expected, $type)
     {
         $this->expectWarning();
         $this->expectWarningMessage(
-            "The provided type for `${inputParam}` value was `"
+            "The provided type for `{$inputParam}` value was `"
             . (gettype($inputValue) === 'double' ? 'float' : gettype($inputValue))
             . "`. The modeled type is `{$type}`."
         );